Some bugs found after first installation

  • ets-media
  • ets-media's Avatar Topic Author
  • Offline
  • New Member
  • New Member
More
1 year 6 months ago - 1 year 6 months ago #1 by ets-media
Some bugs found after first installation was created by ets-media
hi mavrosxristoforos team.

first many thanks for nice extensions, I was looking for an replacement of another extension of this kind which is not supported in J5 anymore I think this one can replace it. After first installation and configuring to my need I have found some bugs.

I will try to describe them:

P1 - the menu item of "MyShortlist Default Layout" for not logged in users throws a Joomla exception instead of redirect the user to login page.
P2 - the menu item of type MyShortlist does not contain the configuration option "Include Icon Library" which exists in the configuration of MyShortlist modules. On my page I do not want to use the performance-killer awesome-fontts. So as consequence when I use MyShortlist as module I can disable them but only when I display the component by menu item I am not able to disable awsome fonts. (additionally the plugin loads the Awesome fonts from external URL - potential problem for website with strict CORS)
P3 - many text label can be configured directly in the module settings, but the most "visible" ADD_TO_LIST constant displayed on the button cannot. I had to use language overwrite to change it. Why this one is not included in the module configuration?
P4 - the constant ADD_TO_LIST handles both -> label on the button and the title in the popup. It should be split to 2 constants, e.g. in my case I display button without any text (just using nice background image) but still would like to keep the title "Add to list" in the popup. So I had to set the ADD_TO_LIST to empty value but therefore both - popup title and button label disappers.
P5 - Please sourround the text "Available Lists:" in the myshortlist_lists_interface and "Add New List:" in the form <form method="post" onSubmit="return msl_checkListName('mi448');">Add New List: <--- with any kind of html element, like <p> otherwise is not possible to style it with css
P6 - the popup about "Added to Favorites" is not mobile friendly. Is displayed as narrow rectangle in the middle of the screen
P7 - on the mobile (IOS+Chrome) the names of lists are displayed blank (not visible) - I have fixed it myself by customizing css
P8 - when I create a new list with special characters in the name like "Johny & Marry" it displays then incorrectly with html entity escaping, like: "Johny &amp marry"
P9 - please use for all language constants any additional special prefix and avoid generic constants like YOUR_NAME, ADD_TO_LIST - to avoid conflicts. I see you already use some mix constants with prefix MSL and some without any (MSL_FIELD_IS_REQUIRED , FIELD_IS_REQUIRED)
P10 - the view of favorites is not responsive. Instead of defining fixed number of elements in a row is better to define all "myshortlist_item" as display:inline-block and let to configure only the width of single item in terms of total with in percentage, like 50%, 33% to automatically scale the view to the screen size
P11 - I have set to OFF "Show Delete Confirmation" and "Show Popup after Add" in the module "Youtube-Like Lists Dropdown" but the popups still come up.

in attachment my optimisation of css styles to make the component more mobile friendly and responsive (css file + some screenshots after corrections)

could you please solve all those issues ?
many thanks in advance
Marcin

Fix for Popup "Added to List" mobile/desktop:
Code:
@media (min-width: 768px) {   .msl-popup-active {      left: max(25%, 100px);      width: 50%;   } } @media (max-width: 767px) {   .msl-popup-active {      left: min(10%, 100px);      width: 80%;   } }
 
Last edit: 1 year 6 months ago by ets-media.

Please Log in or Create an account to join the conversation.

  • Christopher Mavros
  • Christopher Mavros's Avatar
  • Offline
  • Administrator
  • Administrator
More
1 year 3 weeks ago #2 by Christopher Mavros
Replied by Christopher Mavros on topic Some bugs found after first installation
Hello Marcin.
I apologize for the very late response. I was confined to bed at the time of your post and the amount of stacked work along with the size of this post did not allow me to handle it until now.
For your next posts, please try to separate issues to one per topic, otherwise it's better to just send me a direct message through the contact form.

P1. I cannot replicate this. Please send me an email with the thrown error.
P2. Ok. This option will be included in the menu item in the next release.
P3. At some point, we decided to use language strings instead of text options. This is only displayed for Youtube-like dropdowns, so it's not very common. You can easily override it by going to Language Overrides, as you described.
P4. I see. You would have to use a template override to achieve what you want. Simply copy the file modules/mod_myshortlist/tmpl/default_list_checkboxes.php to templates/your_template/html/mod_myshortlist/default_list_checkboxes.php and change the header text.
P5. This will be included in the next release.
P6. I have improved the mobile-friendliness of the popup. It will be included in the next release.
P7. I can't replicate this issue. Are you sure it's not caused from your template?
P8. Our implementation of lists does have some limitations. We hope to remedy such issues at some point.
P9. MyShortlist was first released in 2011. Back then, documentation for what you are saying was sparse. Since these were originally included as plain keys (without a prefix) we had to maintain them for backwards compatibility with existing overrides. So far we haven't had a report of conflicts.
P10. The view is not automatically adjusting columns, but it is responsive. Feel free to post this on the Suggestions category.
P11. The delete confirmation and the item added popup are not relevant to the Youtube-like dropdown mode. I can't replicate what you are saying.

I appreciate your understanding. Please split further issues in separate topics.
Thanks again.

Christopher Mavros
me@mavxr.com
If you like our extensions, please rate us on the JED!

Please Log in or Create an account to join the conversation.

Moderators: Christopher Mavros